Avoid dormant ATT signatures in app binaries - #496
Draft
thisislvca wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notDeterminedfallbacks so its method signature is not emitted into the framework binaryWhy
App Store Connect can infer that an app uses App Tracking Transparency from dormant identifiers and Objective-C method signatures in a bundled SDK, even when the app never requests tracking permission. This can trigger tracking declarations or review questions for apps that do not use ATT.
The ATT implementation remains available when
ATTrackingManagerexists. If it is unavailable, the proxy continues to returnnotDetermined, matching the previous fallback behavior.Fixes #495
Validation
TrackingManagerProxyTests: 6 tests passed on an iPhone 17 Pro simulatorSuperwallKit.frameworkscanned withstrings; no matches forNSUserTrackingUsageDescription,requestTrackingAuthorizationWithCompletionHandler:, orrequestTrackingAuthorization()git diff --checkpassescc @yusuftor @jakemor @anglinb